Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework injection and synchronisation for Linux on musl-libc #3231

Closed
wants to merge 2 commits into from

Conversation

jmaselbas
Copy link

for the record, modification applied to fix #3228
This is a bit of a hack and could be more clean or even the only implementation for all posix systems.
Also only tested with musl, not with glibc.

@baldurk
Copy link
Owner

baldurk commented Jan 22, 2024

This is not a change I want to make, since as mentioned in that issue supporting musl is not something I plan to do.

I don't want to make large refactors to this code without a sufficient reason as it's an area that is quite brittle given how varied and unreliable linux can be in this regard. In my experience any code relying on the use of signals is a source of bugs as I've found them to be quite unreliable.

If you want to keep this code locally for use then you are free to do so, though I can't guarantee this will work in all situations or remain working in future.

@baldurk baldurk closed this Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Injection failed on linux with musl-libc
2 participants